Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign Windows release binaries #638

Merged
merged 4 commits into from
Jan 27, 2025

Conversation

rquitales
Copy link
Member

Proposed changes

This PR adds a new Makefile target make sign-goreleaser-exe target to sign all built GoReleaser windows binaries. This PR contains 2 changes:

Please see the linked ci-mgmt issue for status of GitHub actions workflows to validate that the binaries are signed.

@rquitales rquitales requested a review from a team January 27, 2025 19:04
@rquitales rquitales self-assigned this Jan 27, 2025
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.33%. Comparing base (2347595) to head (da780a2).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #638   +/-   ##
=======================================
  Coverage   33.33%   33.33%           
=======================================
  Files          24       24           
  Lines         978      978           
=======================================
  Hits          326      326           
  Misses        605      605           
  Partials       47       47           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rquitales rquitales merged commit a8d6707 into master Jan 27, 2025
19 checks passed
@rquitales rquitales deleted the rquitales/add-windows-signing-make-target branch January 27, 2025 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants