Add another example and map additional resources #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds tests for additional resources and adds mappings for very common resources that do not yet have CCAPI support. - AWS::SQS::QueuePolicy - AWS::SNS::TopicPolicy ``` aws-native:sns:Subscription aws-native:sqs:Queue aws-native:sns:Topic aws-native:sns:Subscription aws-native:sqs:Queue aws-native:iam:Role aws-native:lambda:Function aws-native:events:EventBus aws-native:events:Rule aws-native:events:Rule aws-native:sns:Topic ```
t0yv0
reviewed
Oct 25, 2024
| let client: EventBridgeClient; | ||
|
|
||
| export const handler = async function (event, context) { | ||
| if (!client) { |
There was a problem hiding this comment.
Nit: hide this in getOrCreateClient()?
t0yv0
reviewed
Oct 25, 2024
| import { | ||
| aws_events, | ||
| aws_events_targets, | ||
| aws_lambda, |
There was a problem hiding this comment.
Interesting that aws-cdk-lib uses this_not_so_native_typescript_casing.
t0yv0
reviewed
Oct 25, 2024
| rawMessageDelivery: true, | ||
| }), | ||
| ); | ||
| this.synth(); |
There was a problem hiding this comment.
Curious do we have user code call synth() or does the framework call it? We imitate how CDK code is written here right?
There was a problem hiding this comment.
Right now no. The user has to explicitly call this.synth() which is not imitating how CDK works. In #170 we will change this so the user won't have to.
t0yv0
approved these changes
Oct 25, 2024
|
This PR has been shipped in release v1.0.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tests for additional resources and adds mappings for very common
resources that do not yet have CCAPI support.