Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch frontdoor permadiff #2014

Merged
merged 2 commits into from
May 9, 2024
Merged

Conversation

VenelinMartinov
Copy link
Contributor

@VenelinMartinov VenelinMartinov commented May 8, 2024

fixes #1421 by patching the upstream resource to be computed as the provider sets a value for it. This is needed for pulumi/pulumi-terraform-bridge#1936

works around hashicorp/terraform-provider-azurerm#25911

issue for patch: #2015

upstream PR: hashicorp/terraform-provider-azurerm#25912

Copy link

github-actions bot commented May 8, 2024

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

Copy link

github-actions bot commented May 8, 2024

Is README.md missing any configuration options?

auxiliaryTenantIds not found in Configuration section
clientCertificate not found in Configuration section
clientCertificatePassword not found in Configuration section
clientCertificatePath not found in Configuration section
clientId not found in Configuration section
clientIdFilePath not found in Configuration section
clientSecret not found in Configuration section
clientSecretFilePath not found in Configuration section
disableCorrelationRequestId not found in Configuration section
disableTerraformPartnerId not found in Configuration section
environment not found in Configuration section
features not found in Configuration section
location not found in Configuration section
metadataHost not found in Configuration section
msiEndpoint not found in Configuration section
oidcRequestToken not found in Configuration section
oidcRequestUrl not found in Configuration section
oidcToken not found in Configuration section
oidcTokenFilePath not found in Configuration section
partnerId not found in Configuration section
skipProviderRegistration not found in Configuration section
storageUseAzuread not found in Configuration section
subscriptionId not found in Configuration section
tenantId not found in Configuration section
useAksWorkloadIdentity not found in Configuration section
useCli not found in Configuration section
useMsi not found in Configuration section
useOidc not found in Configuration section

Please add a description for each of these options to README.md. Details about them can be found in either the upstream docs or schema.json.

@VenelinMartinov VenelinMartinov merged commit c70fbe2 into master May 9, 2024
17 checks passed
@VenelinMartinov VenelinMartinov deleted the vvm/patch_frontdoor_permadiff1 branch May 9, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Frontdoor compatible with XSkipDetailedDiffForChanges
2 participants