Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort (and deduplicate) type aliases #3902

Merged
merged 2 commits into from
Jan 29, 2025
Merged

Sort (and deduplicate) type aliases #3902

merged 2 commits into from
Jan 29, 2025

Conversation

danielrbradley
Copy link
Member

  • Use a set to ensure we don't add duplicate aliases.
  • Render the aliases ordered.

This just affects explicit versions, moving the default version from the first alias to the last in the list.

This will allow us to add additional sources of aliases (from the previous major version) without causing duplicates.

Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 57.06%. Comparing base (0a344cb) to head (93c9cb7).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
provider/pkg/gen/schema.go 92.85% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3902   +/-   ##
=======================================
  Coverage   57.06%   57.06%           
=======================================
  Files          78       78           
  Lines       12469    12470    +1     
=======================================
+ Hits         7115     7116    +1     
  Misses       4807     4807           
  Partials      547      547           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

provider/pkg/gen/schema.go Outdated Show resolved Hide resolved
- Use a set to ensure we don't add duplicate aliases.
- Render the aliases ordered.

This just affects explicit versions, moving the default version from the first alias to the last in the list.

This will allow us to add additional sources of aliases (from the previous major version) without causing duplicates.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants