Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A new report listing API versions that are old enough to be removed #3899

Merged
merged 4 commits into from
Jan 29, 2025

Conversation

thomas11
Copy link
Contributor

@thomas11 thomas11 commented Jan 28, 2025

Part of #3422. Determine API versions that are older than any previous default version in a module. These are good candidates for removal.

@thomas11 thomas11 self-assigned this Jan 28, 2025
@thomas11 thomas11 requested review from danielrbradley, EronWright and a team January 28, 2025 13:25
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Copy link
Member

@danielrbradley danielrbradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall approach looks sensible 👍

The main algorithm could do with a couple of comments helping explain the rational of each major step.

Also, looks like there's a diff in the generated file in CI that we'll need to resolve.

provider/pkg/versioning/gen.go Outdated Show resolved Hide resolved
provider/pkg/versioning/gen.go Outdated Show resolved Hide resolved
Copy link
Member

@danielrbradley danielrbradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, minor nit inline, also could add a line to the reports/README.md to explain the purpose of the new report.

provider/pkg/versioning/gen.go Outdated Show resolved Hide resolved
@thomas11 thomas11 force-pushed the tkappler/old-versions-report branch from aff35af to af0e097 Compare January 28, 2025 15:45
@thomas11 thomas11 force-pushed the tkappler/old-versions-report branch from af0e097 to 748290f Compare January 28, 2025 15:46
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 0% with 33 lines in your changes missing coverage. Please review.

Project coverage is 57.05%. Comparing base (9a92d17) to head (748290f).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
provider/pkg/versioning/gen.go 0.00% 31 Missing ⚠️
provider/pkg/versioning/build_schema.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3899      +/-   ##
==========================================
- Coverage   57.21%   57.05%   -0.16%     
==========================================
  Files          78       78              
  Lines       12436    12469      +33     
==========================================
- Hits         7115     7114       -1     
- Misses       4774     4808      +34     
  Partials      547      547              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thomas11 thomas11 merged commit 0a344cb into master Jan 29, 2025
23 checks passed
@thomas11 thomas11 deleted the tkappler/old-versions-report branch January 29, 2025 04:36
@thomas11 thomas11 mentioned this pull request Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants