Don't upload codecov data from autorest and release jobs #3725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3725 +/- ##
=======================================
Coverage 56.41% 56.41%
=======================================
Files 74 74
Lines 11813 11813
=======================================
Hits 6664 6664
Misses 4652 4652
Partials 497 497 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
mikhailshilkov
temporarily deployed
to
env-ci
GitHub Actions
Inactive
mikhailshilkov
temporarily deployed
to
env-ci
GitHub Actions
Inactive
mikhailshilkov
temporarily deployed
to
env-ci
GitHub Actions
Inactive
mikhailshilkov
temporarily deployed
to
env-ci
GitHub Actions
Inactive
mikhailshilkov
temporarily deployed
to
env-ci
GitHub Actions
Inactive
mikhailshilkov
deleted the
mikhailshilkov/reduce-codecov-report-noise
branch
|
This PR has been shipped in release v2.74.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently have a problem in historic codecov data where coverage jumps up and down between master commits. Examples
It turns out that the larger coverage number comes from two or three CI jobs (master + scheduled autorest + release) and lower number is just from master. Since we can't guarantee that we will run a release and an autorest nightly on every commit, this PR disables coverage data on those jobs.
We lose a little bit of coverage on that autorest legacy code, but I think stability is more important. Also, a PR vs. master coverage will be directly comparable.