-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New scheduled workflow to test using the azcore backend nightly #3591
Conversation
a056768
to
3a2a716
Compare
Does the PR have any schema changes?Looking good! No breaking changes found. |
3a2a716
to
0872887
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3591 +/- ##
==========================================
+ Coverage 58.97% 59.04% +0.06%
==========================================
Files 68 68
Lines 8656 8658 +2
==========================================
+ Hits 5105 5112 +7
+ Misses 3081 3077 -4
+ Partials 470 469 -1 ☔ View full report in Codecov by Sentry. |
71b1056
to
b40392c
Compare
b40392c
to
b52fe1c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! That approach looks sound to me
This PR has been shipped in release v2.64.0. |
Since we chose an opt-in approach for the time being, the new azcore client from #3536 is not tested by regular CI workflows. This PR adds a nightly workflow that tests it. It's a stripped-down copy of
master.yaml
.We can then easily add the opt-in for azidentity auth as well.
Here's a recent run. The only failures are OIDC tests, which should pass on
master
because there's an identity defined on our Service Principal for the master branch.