Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New scheduled workflow to test using the azcore backend nightly #3591

Merged
merged 6 commits into from
Sep 30, 2024

Conversation

thomas11
Copy link
Contributor

@thomas11 thomas11 commented Sep 25, 2024

Since we chose an opt-in approach for the time being, the new azcore client from #3536 is not tested by regular CI workflows. This PR adds a nightly workflow that tests it. It's a stripped-down copy of master.yaml.

We can then easily add the opt-in for azidentity auth as well.

Here's a recent run. The only failures are OIDC tests, which should pass on master because there's an identity defined on our Service Principal for the master branch.

@thomas11 thomas11 force-pushed the tkappler/azcore-scheduled branch from a056768 to 3a2a716 Compare September 25, 2024 14:43
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@thomas11 thomas11 force-pushed the tkappler/azcore-scheduled branch from 3a2a716 to 0872887 Compare September 25, 2024 14:49
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.04%. Comparing base (8e65c18) to head (e1f3ba9).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3591      +/-   ##
==========================================
+ Coverage   58.97%   59.04%   +0.06%     
==========================================
  Files          68       68              
  Lines        8656     8658       +2     
==========================================
+ Hits         5105     5112       +7     
+ Misses       3081     3077       -4     
+ Partials      470      469       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thomas11 thomas11 requested review from a team and danielrbradley September 26, 2024 12:52
@thomas11 thomas11 force-pushed the tkappler/azcore-scheduled branch 2 times, most recently from 71b1056 to b40392c Compare September 26, 2024 15:32
@thomas11 thomas11 force-pushed the tkappler/azcore-scheduled branch from b40392c to b52fe1c Compare September 27, 2024 09:28
Copy link
Member

@danielrbradley danielrbradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! That approach looks sound to me :shipit:

@thomas11 thomas11 merged commit cf9de59 into master Sep 30, 2024
25 checks passed
@thomas11 thomas11 deleted the tkappler/azcore-scheduled branch September 30, 2024 08:29
@pulumi-bot
Copy link
Contributor

This PR has been shipped in release v2.64.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants