Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new reusable actions #3247

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Use new reusable actions #3247

merged 2 commits into from
Apr 30, 2024

Conversation

danielrbradley
Copy link
Member

  1. Use version action for all workflows - the new action works for both dev and release versions.
  2. Use new check-git-status action.

@danielrbradley danielrbradley requested a review from thomas11 April 29, 2024 14:49
@danielrbradley danielrbradley self-assigned this Apr 29, 2024
Copy link

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.34%. Comparing base (509a5d2) to head (7069c10).

❗ Current head 7069c10 differs from pull request most recent head 559ca19. Consider uploading reports for the commit 559ca19 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3247      +/-   ##
==========================================
- Coverage   55.37%   55.34%   -0.03%     
==========================================
  Files          66       66              
  Lines        9924     9929       +5     
==========================================
  Hits         5495     5495              
- Misses       3996     4001       +5     
  Partials      433      433              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielrbradley
Copy link
Member Author

It appears the changes being flagged are from 9b47251 which didn't re-generate the SDKs

1. Use version action for all workflows - the new action works for both dev and release versions.
2. Use new check-git-status action.
@danielrbradley
Copy link
Member Author

Rebased to fix outdated files

@danielrbradley danielrbradley enabled auto-merge (squash) April 30, 2024 12:27
@danielrbradley danielrbradley merged commit f623d85 into master Apr 30, 2024
23 checks passed
@danielrbradley danielrbradley deleted the reusable-actions branch April 30, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants