Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add imageName param to ECR image args #1257

Merged
merged 3 commits into from
Apr 12, 2024
Merged

Add imageName param to ECR image args #1257

merged 3 commits into from
Apr 12, 2024

Conversation

sav-valerio
Copy link
Contributor

Fixes #1171

This allows the user to manually choose the name of the underlying Pulumi Docker image resource

When not defined it will fall back to the original behavior (use the image tag as the name of the underlying resource)

@sav-valerio
Add imageName param to ECR image args
85fdc9a 
This allows the user to manually choose the name of the underlying Pulumi Docker image resource

When not defined it will fall back to the original behavior (use the image tag as the name of the underlying resource)
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2024

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@sav-valerio sav-valerio changed the title Add imageName param to ECR image args Add imageName param to ECR image args for the underlying Docker resource Apr 9, 2024
@sav-valerio sav-valerio changed the title Add imageName param to ECR image args for the underlying Docker resource Add imageName param to ECR image args Apr 9, 2024
@sav-valerio sav-valerio mentioned this pull request Apr 9, 2024
Closed
@mikhailshilkov
Copy link
Member

/run-acceptance-tests

@github-actions GitHub Actions
Copy link

Please view the PR build - https://github.com/pulumi/pulumi-awsx/actions/runs/8658504358

@github-actions GitHub Actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@github-actions GitHub Actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@t0yv0
Copy link
Member

t0yv0 commented Apr 12, 2024

/run-acceptance-tests

@github-actions GitHub Actions
Copy link

Please view the PR build - https://github.com/pulumi/pulumi-awsx/actions/runs/8666196198

@t0yv0
Copy link
Member

t0yv0 commented Apr 12, 2024

The failing test is a known flake, skipping in #1260

LGTM, thanks so much for this contribution!

@t0yv0 t0yv0 merged commit 7d35941 into pulumi:master Apr 12, 2024
5 of 6 checks passed
@danielrbradley danielrbradley mentioned this pull request Dec 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t0yv0 t0yv0 t0yv0 approved these changes

@corymhall corymhall Awaiting requested review from corymhall

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Building different targets on same Dockerfile causes a Duplicate resource URN error
3 participants
@sav-valerio @mikhailshilkov @t0yv0