Skip to content

Commit

Permalink
Fix make target "discovery" by correctly escaping commands (#1611)
Browse files Browse the repository at this point in the history
The awk command of the `discovery` make target was not correctly escaped
and ended up discovering the wrong version.

Instead of detecting `8bed56da0b8e0f6bb7c2d255194694bba97bb28f` it
detected `8bed56da0b8e0f6bb7c2d255194694bba97bb28f refs/heads/main`
which ended up breaking the docs generation.

fixes #1609
  • Loading branch information
flostadler authored Jun 28, 2024
1 parent 40c1856 commit bc49058
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ docs:: .docs.version
$(WORKING_DIR)/bin/$(CODEGEN) -schema-folder $(CFN_SCHEMA_DIR) -version ${VERSION_GENERIC} -docs-url https://github.com/cdklabs/awscdk-service-spec/raw/${DOCS_VERSION}/sources/CloudFormationDocumentation/CloudFormationDocumentation.json docs

discovery:: update_submodules codegen
git ls-remote https://github.com/cdklabs/awscdk-service-spec refs/heads/main | awk '{print $1}' > .docs.version
git ls-remote https://github.com/cdklabs/awscdk-service-spec refs/heads/main | awk '{print $$1}' > .docs.version
$(WORKING_DIR)/bin/$(CODEGEN) -schema-folder $(CFN_SCHEMA_DIR) -version ${VERSION_GENERIC} -schema-urls https://schema.cloudformation.us-east-1.amazonaws.com/CloudformationSchema.zip,https://schema.cloudformation.us-west-2.amazonaws.com/CloudformationSchema.zip discovery

ensure:: init_submodules
Expand Down

0 comments on commit bc49058

Please sign in to comment.