-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only test new or update programs on PRs #13842
Conversation
Your site preview for commit b6f2de4 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-13842-b6f2de43.s3-website.us-west-2.amazonaws.com. |
Your site preview for commit 141128a is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-13842-141128a3.s3-website.us-west-2.amazonaws.com. |
Your site preview for commit 030bb45 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-13842-030bb45a.s3-website.us-west-2.amazonaws.com. |
Your site preview for commit 95f6cd3 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-13842-95f6cd39.s3-website.us-west-2.amazonaws.com. |
Added |
Your site preview for commit 7416024 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-13842-74160243.s3-website.us-west-2.amazonaws.com. |
Your site preview for commit a31be35 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-13842-a31be352.s3-website.us-west-2.amazonaws.com. |
Your site preview for commit bc9891f is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-13842-bc9891f9.s3-website.us-west-2.amazonaws.com. |
Your site preview for commit cec4d59 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-13842-cec4d59b.s3-website.us-west-2.amazonaws.com. |
@thoward I updated the code a bit and configured the workflow to fetch the master branch also. Here is a run I did with programs to test: https://github.com/pulumi/docs/actions/runs/12839419847/job/35806652614 |
Your site preview for commit 6b16dd7 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-13842-6b16dd79.s3-website.us-west-2.amazonaws.com. |
…pr' into sean/test-programs-pr
Your site preview for commit 7332b35 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-13842-7332b352.s3-website.us-west-2.amazonaws.com. |
@@ -0,0 +1,136 @@ | |||
# Code Examples in Docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great; one thought though this doc does not describe how the testing will happen as part of the PR build; and how you'd see the success/failures in the logs ? Can we add that as well?
… using a Makefile/unit testing a policy
Co-authored-by: James Denyer <[email protected]>
Your site preview for commit 6b07cd9 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-13842-6b07cd9a.s3-website.us-west-2.amazonaws.com. |
Your site preview for commit 2b572a5 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-13842-2b572a5f.s3-website.us-west-2.amazonaws.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job! We really appreciate the contribution.
This PR enables testing of the programs in static/programs dir that is the source for our tested code examples. This will allow those tests to run at PR time and also only runs against the ones that are new or changed.