Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only test new or update programs on PRs #13842

Merged
merged 15 commits into from
Jan 30, 2025
Merged

Only test new or update programs on PRs #13842

merged 15 commits into from
Jan 30, 2025

Conversation

sean1588
Copy link
Member

This PR enables testing of the programs in static/programs dir that is the source for our tested code examples. This will allow those tests to run at PR time and also only runs against the ones that are new or changed.

@pulumi-bot
Copy link
Collaborator

@pulumi-bot
Copy link
Collaborator

@pulumi-bot
Copy link
Collaborator

@pulumi-bot
Copy link
Collaborator

@thoward
Copy link
Contributor

thoward commented Jan 17, 2025

Added CODE-EXAMPLES.md docs

@pulumi-bot
Copy link
Collaborator

@pulumi-bot
Copy link
Collaborator

@pulumi-bot
Copy link
Collaborator

@pulumi-bot
Copy link
Collaborator

@sean1588
Copy link
Member Author

@thoward I updated the code a bit and configured the workflow to fetch the master branch also.

Here is a run I did with programs to test: https://github.com/pulumi/docs/actions/runs/12839419847/job/35806652614

@pulumi-bot
Copy link
Collaborator

@pulumi-bot
Copy link
Collaborator

@@ -0,0 +1,136 @@
# Code Examples in Docs
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great; one thought though this doc does not describe how the testing will happen as part of the PR build; and how you'd see the success/failures in the logs ? Can we add that as well?

Co-authored-by: James Denyer <[email protected]>
@pulumi-bot
Copy link
Collaborator

@pulumi-bot
Copy link
Collaborator

Copy link
Contributor

@thoward thoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! We really appreciate the contribution.

@sean1588 sean1588 merged commit 3081a3f into master Jan 30, 2025
9 checks passed
@sean1588 sean1588 deleted the sean/test-programs-pr branch January 30, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants