Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update jasmine to 2.x #990

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Update jasmine to 2.x #990

wants to merge 12 commits into from

Commits on Aug 4, 2024

  1. Remove run-tests scripts 

    Pro:
* Less code to maintain & update
* run-package-tests was unused

Con:
* Lost the formatting
    @kiskoza
    kiskoza committed Aug 4, 2024
    Configuration menu
    Copy the full SHA
    9839700 View commit details
    Browse the repository at this point in the history

  2. Drop support for JUnit XML output for tests 

    Pro:
* Less code to maintain
    @kiskoza
    kiskoza committed Aug 4, 2024
    Configuration menu
    Copy the full SHA
    60f2559 View commit details
    Browse the repository at this point in the history

  3. Introduce helper/jasmine-singleton to have reference only to the vend… 

    …ored jasmine

* only the vendored version got used during the tests
* don't need to require jasmine multiple times

Clean up vendored jasmine to make it easier to upgrade

Remove checks about global jasmine as we're not setting it anymore
    @kiskoza
    kiskoza committed Aug 4, 2024
    Configuration menu
    Copy the full SHA
    895f5e5 View commit details
    Browse the repository at this point in the history

  4. Move jasmine-test-runner to be under spec/runners

    @kiskoza
    kiskoza committed Aug 4, 2024
    Configuration menu
    Copy the full SHA
    ac9ed41 View commit details
    Browse the repository at this point in the history

  5. Introduce jasmine2 test runner

    @kiskoza
    kiskoza committed Aug 4, 2024
    Configuration menu
    Copy the full SHA
    c96d241 View commit details
    Browse the repository at this point in the history

  6. Improve test runner switcher

    @kiskoza
    kiskoza committed Aug 4, 2024
    Configuration menu
    Copy the full SHA
    b5cb438 View commit details
    Browse the repository at this point in the history

  7. Fix spec files running with jasmine 2

    @kiskoza
    kiskoza committed Aug 4, 2024
    Configuration menu
    Copy the full SHA
    d22bfed View commit details
    Browse the repository at this point in the history

  8. Upgrade archive-view to use jasmine2 test runner

    @kiskoza
    kiskoza committed Aug 4, 2024
    Configuration menu
    Copy the full SHA
    edda5f4 View commit details
    Browse the repository at this point in the history

  9. Add retry mechanism to jasmine2 test runner

    @kiskoza
    kiskoza committed Aug 4, 2024
    Configuration menu
    Copy the full SHA
    bef870b View commit details
    Browse the repository at this point in the history

  10. Write a wrapper to eliminate done callbacks from async tests

    @kiskoza
    kiskoza committed Aug 4, 2024
    Configuration menu
    Copy the full SHA
    f5a5b0e View commit details
    Browse the repository at this point in the history

  11. Run flaky spec only on linux

    @kiskoza
    kiskoza committed Aug 4, 2024
    Configuration menu
    Copy the full SHA
    4758360 View commit details
    Browse the repository at this point in the history

  12. Fix the non-headless spec runner 

    Co-authored-by: Andrew Dupont <[email protected]>
    @kiskoza @savetheclocktower
    kiskoza and savetheclocktower committed Aug 4, 2024
    Configuration menu
    Copy the full SHA
    3b17830 View commit details
    Browse the repository at this point in the history