Create bug-free i18n API #473
Draft
+957
−290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It could be an object (like, not yet reached the end and found a string), which wouldn't work here
remnants of before i discovered `PackageManager::getAvailablePackages`
In addition to regular `label` key in a menu item, you can now have a `localisedLabel` key. This can either point to a key, or can point to an object, with properties `key` and `opts` for values to interpolate.
loading is done at startup if present, saving not yet implemented
Move them all to the dynamic place, so that its consistently in one place, and remove the last 2 settings that aren't currently in use
Provided as second argument, so, `activate(_, { t })`
Co-authored-by: confused-Techie <[email protected]>
This is called once in the constructor, then again in `initialize`. The constructor call was too early, and `i18n.t` had not been available yet, but it was used by `loadBundledKeymaps`.
|
rebased onto master (I got a bit really annoyed with git) |
|
All the failures are consistently failing on https://github.com/pulsar-edit/pulsar/blob/i18n/packages/background-tips/lib/tips.js#L3 for some reason |
thought about renaming that function from `buildAtomEnvironment` to `setupAtomEnvironment` because it now sets everything up including putting it onto `window.atom` but i don't wanna touch that ueeeeee
grammar-selector is causing t to be called for `language-test`, which isn't available in `packages.find(p => p.name === ns);` for whatever reason <ignore this>
frenchbread
reviewed
Aug 24, 2023
| @@ -242,7 +241,8 @@ module.exports = MenuManager = class MenuManager { | |||
| } | |||
|
|
|||
| sortPackagesMenu() { | |||
| const packagesMenu = _.find(this.template, ({id}) => MenuHelpers.normalizeLabel(id) === 'Packages'); | |||
| let packagesLabel = this.i18n.t("core.menu.packages.self"); | |||
There was a problem hiding this comment.
Suggested change
| let packagesLabel = this.i18n.t("core.menu.packages.self"); | |
| const packagesLabel = this.i18n.t("core.menu.packages.self"); |
Draft
|
superceded by #715 (I want to keep the branch around for now, Just In Case™ I want to reference something from it, will delete after I'm sure I don't need it anymore) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #446 could have used a bit more testing/validation
(and actually looking at the CI)before merging, and so its been reverted now. This is attempt 2, we try to bug fix and make sure it doesn't break Pulsar before merging.