Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiment: Fix building of AppImage version #1069

Draft
wants to merge 37 commits into
base: master
Choose a base branch
from

Conversation

savetheclocktower
Copy link
Sponsor Contributor

This is another draft based on my work in #1066 and tries to use CI to automate the process I described here of fixing the AppImage after it's generated. I'm not certain I'm doing the processor architecture stuff right, but we'll see what CI says.

@savetheclocktower
Copy link
Sponsor Contributor Author

After a lot of floating trial balloons over the GitHub Actions wall, I've got it working! Next step is to clean it up.

@savetheclocktower
Copy link
Sponsor Contributor Author

OK, I've cleaned up the script and explained it thoroughly so that people understand why it needs to exist.

At this point, I've proven that an AppImage artifact generated by the CI job on this PR branch produces an AppImage that invokes pulsar.sh instead of the pulsar.executable. It does the right things when I run (e.g.) ./Pulsar.AppImage --package list and ./Pulsar.AppImage --wait foo.txt.

I have not yet tried the ARM Linux job on Cirrus, but the step is present in .cirrus.yml.

I'll keep this in draft at least until #1066 is landed, but at least I can think about other things for a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant