Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed delete to beginning and end of line #1036

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mauricioszabo
Copy link
Contributor

After #810, delete to beginning and end of line are broken when soft-wrap is selected.

This PR fixes this behavior, but also changes the way "delete to end of line" works in original Atom - originally, it would delete to the end of the "visible line" - so, if one had the following code:

image

And hit "delete to the end of line", this would be the result:

image

Now, it deletes the whole line:

image

We might want to vote to check if that's the behavior we want

@DeeDeeG
Copy link
Member

DeeDeeG commented Jul 14, 2024

I would agree with doing a vote. For me, deleting to the end of the "visible line" or "visually apparent line" is intuitive.

There is only a difference if there is line wrapping activated, right? So, "only" affects those circumstances. And yet it is a common scenario, so still nice to get the user experience right.

I feel that leaning into the "code editor" role of Pulsar, you might say deleting to the end of the buffer row is more appropriate. Whereas leaning into the "general text editor for lay-people" role/mindset (which Pulsar also fulfills), then deleting to the end of the screen row would be more appropriate. My two cents.

- DeeDeeG

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants