Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix placement of setTimeout #118

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

savetheclocktower
Copy link
Contributor

The command was hanging because setTimeout was being called over and over, rather than just as needed (because the tag wasn't available yet). The setTimeout started out in one wrong place and then I “fixed” it by moving the setTimeout to a different wrong place.

There is a separate issue here: the API calls to GitHub could fail for any number of reasons. One reason they failed for me was because I exceeded the unauthenticated rate limit! This command should at least handle the error cases, but I believe it can also use the very auth token we use for the package backend in order to enable a much higher rate limit. Both of those are worth doing, but I'll save them for a different PR.

Copy link
Member

@DeeDeeG DeeDeeG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested working, thank you very much!

To clarify the issue / expected for anyone just catching up about this problem:

Issue: ppm publish succeeds but never exits.

Expected: ppm publish should succeed and exit, returning the CLI to the user's control for further commands.

Fix: Allows ppm publish to exit as it should after it finishes.

Main test method: Ran ppm publish patch with/without this change to confirm the fix.

Also tried some invalid things to have ppm publish exit with errors, and that worked as it should too.

@DeeDeeG DeeDeeG merged commit 0bc2071 into pulsar-edit:master Dec 19, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants