Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish backporting aiohttp 3.10 bump #6007

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Conversation

gerrod3
Copy link
Contributor

@gerrod3 gerrod3 commented Nov 11, 2024

Bumping this req broke Pulp, but only when using the downloader outside of a coroutine, which some plugins do (pulp_container).

(from commit 3b0d218)

Bumping this req broke Pulp, but only when using the downloader outside of
a coroutine, which some plugins do (pulp_container).
(from commit 3b0d218)
@gerrod3
Copy link
Contributor Author

gerrod3 commented Nov 11, 2024

Side note, we will probably have problems with this again when we upgrade past python 3.12, as it will most likely become an error one day: https://docs.python.org/3.11/library/asyncio-eventloop.html#asyncio.get_event_loop

@ggainey ggainey enabled auto-merge (rebase) November 11, 2024 21:35
@ggainey ggainey merged commit 386c0b9 into pulp:3.49 Nov 11, 2024
12 checks passed
Copy link

patchback bot commented Nov 11, 2024

Backport to 3.22: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.22/386c0b99f2baa9f871c9d0a0be44c2be53581746/pr-6007

Backported as #6008

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Copy link

patchback bot commented Nov 11, 2024

Backport to 3.39: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.39/386c0b99f2baa9f871c9d0a0be44c2be53581746/pr-6007

Backported as #6009

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Copy link

patchback bot commented Nov 11, 2024

Backport to 3.28: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.28/386c0b99f2baa9f871c9d0a0be44c2be53581746/pr-6007

Backported as #6010

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@gerrod3
Copy link
Contributor Author

gerrod3 commented Nov 11, 2024

Uggh, seems like we have an inconsistent test on the azure runner for 3.49. Seems to fail on the retry-with-bad-response test. The fixture seems to be giving an error. Not sure where to start with this one.

@gerrod3 gerrod3 deleted the aiohttp-event-loop branch November 11, 2024 22:23
@ggainey
Copy link
Contributor

ggainey commented Nov 11, 2024

Uggh, seems like we have an inconsistent test on the azure runner for 3.49. Seems to fail on the retry-with-bad-response test. The fixture seems to be giving an error. Not sure where to start with this one.

FWIW, we've been seing a number of inconsistent tests in the nightlies, that "work fine on restart". hard to pin down exactly what is going on - esp when sometimes, it's clearly "github hiccupped/timed-out/etc"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants