Remove functional tests for opentelemetry instrumentation #5994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 981af2e)
ggainey
force-pushed
the
patchback/backports/3.63/981af2ef7b01d19b6b40b2c3c1a5dcbbc0bdf7a7/pr-5962
branch
from
03f1953
to
db5efc4
Compare
|
Need to merge this before any of the 3.63 tests will pass-green |
mdellweg
approved these changes
Nov 11, 2024
Comment on lines
+7
to
+8
| # it is necessary to wait for a short period until the service starts; otherwise, any subsequent requests to Pulp's API endpoints will fail | ||
| sleep 1 |
There was a problem hiding this comment.
Oh, this sounds like superstition. At least the one second is plugged out of thin air.
Maybe ok for here, but we should look into injecting the api_root_rewrite.conf in the containerfile and get rid of restarting a service inside the container altogether.
| @@ -41,6 +41,7 @@ tags | |||
| # Vagrant | |||
| .vagrant | |||
| Vagrantfile | |||
| __pycache__/ | |||
There was a problem hiding this comment.
Of all the ignores on earth, why was this one ever missing? Also this is really python3 specific, not "Vagrant"...
ggainey
deleted the
patchback/backports/3.63/981af2ef7b01d19b6b40b2c3c1a5dcbbc0bdf7a7/pr-5962
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 981af2e)