Add domain and task argument support to TaskSchedule.

CHANGES/5778.feature

@@ -0,0 +1 @@
+Added domain and task arguments when using TaskSchedule to run a task.

docs/dev/learn/other/task-scheduling.md

@@ -8,7 +8,7 @@
 Pulp supports scheduling of tasks. Scheduled tasks will be dispatched shortly after their
 `next_dispatch` time, and be rescheduled one `dispatch_interval` after that, if the latter is
 set. By specifying the `dispatch_interval` as `time_delta(days=1)` you can expect the task
-dispatch to stabily happen at same time every day. Until the last task of the same schedule enters a
+dispatch to stably happen at same time every day. Until the last task of the same schedule enters a
 final state, a new task will not be dispatched. Scheduling is done by the worker processes,
 therefore scheduled task dispatching will be missed if all workers are offline. After an outage
 window, overdue schedules will dispatch at most one task, but down to timing, they may be

pulpcore/app/migrations/0123_taskschedule_pulp_domain_taskschedule_task_args.py

@@ -0,0 +1,24 @@
+# Generated by Django 4.2.16 on 2024-09-09 16:27
+
+from django.db import migrations, models
+import django.db.models.deletion
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('core', '0122_record_last_replication_timestamp'),
+    ]
+
+    operations = [
+        migrations.AddField(
+            model_name='taskschedule',
+            name='pulp_domain',
+            field=models.ForeignKey(null=True, on_delete=django.db.models.deletion.CASCADE, to='core.domain'),
+        ),
+        migrations.AddField(
+            model_name='taskschedule',
+            name='task_args',
+            field=models.TextField(null=True),
+        ),
+    ]

pulpcore/app/models/task.py

@@ -18,6 +18,7 @@
 from pulpcore.app.models import (
     AutoAddObjPermsMixin,
     BaseModel,
+    Domain,
     GenericRelationModel,
 )
 from pulpcore.app.models.status import BaseAppStatus
@@ -371,6 +372,8 @@ class TaskSchedule(BaseModel):
     dispatch_interval = models.DurationField(null=True)
     task_name = models.TextField()
     last_task = models.ForeignKey(Task, null=True, on_delete=models.SET_NULL)
+    pulp_domain = models.ForeignKey(Domain, null=True, on_delete=models.CASCADE)
+    task_args = models.TextField(null=True)
 
     class Meta:
         permissions = [

pulpcore/tasking/_util.py

@@ -1,3 +1,4 @@
+import ast
 import asyncio
 import importlib
 import logging
@@ -209,9 +210,15 @@ def dispatch_scheduled_tasks():
                     # Do not schedule in the past
                     task_schedule.next_dispatch += task_schedule.dispatch_interval
             set_guid(generate_guid())
+            if task_schedule.task_args:
+                task_args = ast.literal_eval(task_schedule.task_args)
+                if not isinstance(task_args, tuple) or not isinstance(task_args, list):
+                    raise Exception("Task args could not been interpreted as a tuple or a list.")
+
             with transaction.atomic():
                 task_schedule.last_task = dispatch(
                     task_schedule.task_name,
+                    task_schedule.task_args
                 )
                 task_schedule.save(update_fields=["next_dispatch", "last_task"])