Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for wrong on_demand serving #3715

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pedro-psb
Copy link
Member

Reproduction for: pulp/pulpcore#5725

Some approaches for solving this:

  • Re-design how RemoteArtifact works.
    • Even though that's a big thing, there are some long-standing unresolved issues around this, so we have the motivation.
  • On sync, clean RemoteArtifacts that were superseded.
    • That means: if we can tell a remote server has replaced Pkg($nevra_A$, $digest_A$) for Pkg($nevra_A$, $digest_B$), the remote artifacts should reflect that.
    • This more consistent state would have avoided this specific issue, but it feels not so straightfoward to implement.
    • May not make sense if we want to move foward with the broader RA approach.
  • On content-app, prioritize remotes associated with the distribution under request
    • As shown here, that's is not a general solution.
    • Again, may not make sense if we want to move foward with the RA re-design approach.
    • As a second plan, that has a low cost for solving only this case and I can't think of any immediate drawbacks.
  • On content-app, assure all selected remotes are tried:
    • This feels non-exclusive with others, because that's what I believe it should be doing.
    • On the other hand, it may do "things work" at the cost of taking longer silently. Because we currently can't select the right remote for the general case, it will brute-force until it hopefully works.
    • It's a low-cost approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant