-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.18 CI failures investigation #3684
Conversation
4dbfc79
to
e217107
Compare
Yet another different error, now with lowerbounds: https://github.com/pulp/pulp_rpm/actions/runs/9995508651/job/27627937853?pr=3684#step:13:439 Edit: not only this one :( |
e217107
to
ac4ba98
Compare
Is updating to centos9 a requirement here? This is the 3.18 branch, no downstream user was ever using it with EL9 so I'd prefer that the CI stayed on EL8 - if we can do that. If we cannot do that easily then I'm ok with it. |
It's not, I was just experimenting in the hope of getting more clues (no luck, though) |
requirements.txt
Outdated
PyGObject>=3.40,<3.46 | ||
PyGObject>=3.40,<3.45 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to confirm there never has been a 3.45.* (or they all got deleted). Then this is the right thing to do.
e31116b
to
45ddbcf
Compare
[noissue]
[noissue]
PyGObject has skipped 3.45 release. If they decide to release it, this would be a Y bump for rpm 3.18, since our actual upperbound is effectively <3.45. Also, reverted the centos9 bump, as 3.18 doesnt use that in knonwn prod environments. [noissue]
db3dd7b
to
5a3cffc
Compare
999d630
to
3c8c31b
Compare
[noissue]
3c8c31b
to
3b93330
Compare
Co-authored-by: Grant Gainey <[email protected]>
gobject-introspection needs to be |
Closing because this was an experimental branch for 3.18 errors but
|
Adding "os_required_packages" config will add its items to an os-install step before the build and install steps: https://github.com/pulp/plugin_template/blob/bd7ee18268acd0b676670fbc595511f75e479d08/templates/github/.github/workflows/build.yml.j2#L26-L37
EDIT: Added a second commit with a manual patch of what the plugin_template will do do test if that works. Got different error!
EDIT2: I've seem a similar error before, added a new dependecy and seems to work. Additional context: this was probably broken because the build step now generate bindings without a running instance of pulp (it only requires that the package is installed). Before that change, the os dependencies were working because they were defined in our OCI images.