Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.18 CI failures investigation #3684

Closed
wants to merge 9 commits into from

Conversation

pedro-psb
Copy link
Member

@pedro-psb pedro-psb commented Jul 18, 2024

Adding "os_required_packages" config will add its items to an os-install step before the build and install steps: https://github.com/pulp/plugin_template/blob/bd7ee18268acd0b676670fbc595511f75e479d08/templates/github/.github/workflows/build.yml.j2#L26-L37

EDIT: Added a second commit with a manual patch of what the plugin_template will do do test if that works. Got different error!

EDIT2: I've seem a similar error before, added a new dependecy and seems to work. Additional context: this was probably broken because the build step now generate bindings without a running instance of pulp (it only requires that the package is installed). Before that change, the os dependencies were working because they were defined in our OCI images.

@github-actions github-actions bot added the multi-commit Added when a PR consists of more than one commit label Jul 18, 2024
@pedro-psb pedro-psb force-pushed the fix/ci-3.18-os-dep-issue branch 2 times, most recently from 4dbfc79 to e217107 Compare July 18, 2024 16:51
@pedro-psb
Copy link
Member Author

pedro-psb commented Jul 18, 2024

Yet another different error, now with lowerbounds: https://github.com/pulp/pulp_rpm/actions/runs/9995508651/job/27627937853?pr=3684#step:13:439

Edit: not only this one :(

@pedro-psb pedro-psb changed the title Add PyGObject system dependency to tempalte_config Add PyGObject system dependency to template_config Jul 19, 2024
@dralley
Copy link
Contributor

dralley commented Jul 19, 2024

Is updating to centos9 a requirement here? This is the 3.18 branch, no downstream user was ever using it with EL9 so I'd prefer that the CI stayed on EL8 - if we can do that.

If we cannot do that easily then I'm ok with it.

@pedro-psb
Copy link
Member Author

Is updating to centos9 a requirement here?

It's not, I was just experimenting in the hope of getting more clues (no luck, though)

requirements.txt Outdated
PyGObject>=3.40,<3.46
PyGObject>=3.40,<3.45
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to confirm there never has been a 3.45.* (or they all got deleted). Then this is the right thing to do.

https://pypi.org/project/PyGObject/#history

@pedro-psb pedro-psb force-pushed the fix/ci-3.18-os-dep-issue branch 2 times, most recently from e31116b to 45ddbcf Compare July 22, 2024 18:14
PyGObject has skipped 3.45 release. If they decide to release it,
this would be a Y bump for rpm 3.18, since our actual upperbound
is effectively <3.45.

Also, reverted the centos9 bump, as 3.18 doesnt use that in knonwn prod
environments.

[noissue]
@pedro-psb pedro-psb marked this pull request as draft July 22, 2024 20:12
@pedro-psb pedro-psb changed the title Add PyGObject system dependency to template_config 3.18 CI failures investigation Jul 22, 2024
@pedro-psb pedro-psb force-pushed the fix/ci-3.18-os-dep-issue branch 2 times, most recently from db3dd7b to 5a3cffc Compare July 23, 2024 02:57
@pedro-psb pedro-psb force-pushed the fix/ci-3.18-os-dep-issue branch 3 times, most recently from 999d630 to 3c8c31b Compare July 23, 2024 13:56
.github/workflows/build.yml Outdated Show resolved Hide resolved
@ggainey
Copy link
Contributor

ggainey commented Jul 24, 2024

gobject-introspection needs to be dnf install gobject-introspection - it's in centos9-stream base, should be available

@pedro-psb
Copy link
Member Author

Closing because this was an experimental branch for 3.18 errors but

  • pygobject-related errors is resolved more cleanly in [3.18] Fix PyGObject requirements and deps #3693
  • the latest error (403 instead of 405) is closely reproducible locally (I get 401 instead of the CI 403), so (AFAIK) dont need to play in the CI to work this out

@pedro-psb pedro-psb closed this Jul 24, 2024
@pedro-psb pedro-psb deleted the fix/ci-3.18-os-dep-issue branch July 24, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
multi-commit Added when a PR consists of more than one commit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants