Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #3679/2e0c2933 backport][3.27] Quick fix for AnyType ruby bindings #3680

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Jul 10, 2024

This is a backport of PR #3679 as merged into main (2e0c293).

Quicker alternative to #3653 for fixing #3639

I must add that this is not the "correct way" of fixing it, but its quick and safe (in the sense that it leaves us in a similar state we had before, where all jsonfields were recognized as Objects). Its not the correct way because:

  • the schema type is misleading, which is not helpful for users. E.g, its says its an Object (openapi type) when its an Array example
  • its not doing basic structural validation (often we know exactly what the json structure is)

Reference

The JSONField was yielding an empty type on the schema, which
broke bindings generation.

This replaces drf serializers.JSONField with a custom one that is an
OpenApi 'object' type.

Closes: #3639
(cherry picked from commit 2e0c293)
@dralley dralley merged commit f8bac10 into 3.27 Jul 11, 2024
14 of 16 checks passed
@dralley dralley deleted the patchback/backports/3.27/2e0c2933675c0ce41d8ac5c801f8d0dbc54349d8/pr-3679 branch July 11, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants