Deprecate 'package_checksum_type' and 'metadata_checksum_type' #3342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm splitting this PR off of the other one, they're worth keeping separate. |
dralley
force-pushed
the
deprecate-checksum-types
branch
2 times, most recently
from
fd330b8
to
47fd2ba
Compare
dralley
force-pushed
the
deprecate-checksum-types
branch
from
47fd2ba
to
a107bbc
Compare
ipanova
approved these changes
Nov 30, 2023
ipanova
reviewed
Nov 30, 2023
| publication.package_checksum_type = ( | ||
| checksum_types.get("package") or publication.metadata_checksum_type | ||
| ) | ||
| checksum_type = get_checksum_type("primary", checksum_types) |
There was a problem hiding this comment.
No, this code is correct. If you look at the definition of get_checksum_type(), it does query "general" first. The string "primary" is used when looking up the original metadata checksum type noted at sync time, if the user didn't specify one. And if the repo wasn't recently synced and the user didn't provide a specific one, then it falls back to default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2480