Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added skip_if_unavailable option to the config.repo file. #3246

Closed
wants to merge 1 commit into from

Conversation

ipanova
Copy link
Member

@ipanova ipanova commented Sep 7, 2023

closes #2902

@ipanova ipanova marked this pull request as draft September 7, 2023 10:18
@ipanova
Copy link
Member Author

ipanova commented Sep 7, 2023

I am not sure I like this pattern adding config.repo options to both Repo and Publication models. Before I get to configurable gpgkey option, should we change what we're doing here? e.g. add a jsonfield to the publication/repo that will be storing the config?

If we do not foresee further requests to add more options to the config.repo we can probably leave this as is, especially if by default its generation will be turned off...but adding every time new field to 2 models is not sustainable.

@ggainey
Copy link
Contributor

ggainey commented Sep 7, 2023

I think we'd be better off having a config.repo JSON field, where a user can set whatever they want the defaults to be. That would let us answer #2902, #2903, and #2985 all at once.

(Note from discussion Elsewhere - this is on Repo because at autopublish time we need it when we don't have a Publication, and it's on Publication because that's where it was originally)

@dralley
Copy link
Contributor

dralley commented Oct 24, 2023

replaced by #3298

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support repository option skip_if_unavailable
3 participants