Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mirror option to optimize sync #1026

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Add mirror option to optimize sync #1026

merged 1 commit into from
Feb 29, 2024

Conversation

hstct
Copy link
Contributor

@hstct hstct commented Feb 27, 2024 •
edited
Loading

closes #1027

@hstct hstct force-pushed the fix-mirror-optimize branch 4 times, most recently from 3903223 to 5873fbe Compare February 28, 2024 13:20
@quba42
Copy link
Collaborator

quba42 commented Feb 29, 2024

Just tested the case where the upstream repo does not have all three release-file types, which also works.

quba42
quba42 requested changes Feb 29, 2024
View reviewed changes
Copy link
Collaborator

@quba42 quba42 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a few small conditional checks we still need, but most of the main use cases are working as expected. We should be able to finish this soon.

Also, feel free to add final touches like an issue and a changelog note.

@quba42 quba42 linked an issue Feb 29, 2024 that may be closed by this pull request
Enable full skip mode when using optimize with mirror mode #1027
Closed
@hstct hstct marked this pull request as ready for review February 29, 2024 11:13
@hstct hstct force-pushed the fix-mirror-optimize branch 5 times, most recently from ae625f2 to 4890d0f Compare February 29, 2024 12:43
quba42
quba42 reviewed Feb 29, 2024
View reviewed changes
@hstct hstct force-pushed the fix-mirror-optimize branch from 4890d0f to ce4aaa1 Compare February 29, 2024 14:20
@quba42 quba42 force-pushed the fix-mirror-optimize branch from ce4aaa1 to f759ad3 Compare February 29, 2024 14:50
@quba42 quba42 force-pushed the fix-mirror-optimize branch from f759ad3 to 7fc41b8 Compare February 29, 2024 14:52
quba42
quba42 approved these changes Feb 29, 2024
View reviewed changes
Copy link
Collaborator

@quba42 quba42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@hstct hstct merged commit 187602d into pulp:main Feb 29, 2024
11 checks passed
@hstct hstct deleted the fix-mirror-optimize branch February 29, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quba42 quba42 quba42 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable full skip mode when using optimize with mirror mode
2 participants
@hstct @quba42