Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New gen-client.sh for offline generation #91

Merged
merged 2 commits into from
Jun 19, 2024
Merged

Conversation

mdellweg
Copy link
Member

This makes shellcheck happy.

[noissue]

@mdellweg mdellweg force-pushed the app_label branch 4 times, most recently from ba44f36 to 037603e Compare January 10, 2024 09:45
Copy link
Member

@pedro-psb pedro-psb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does -z "{value:-}" really makes shellcheck happy? This seems redundant.
But at least makes the line happy

@mdellweg
Copy link
Member Author

Does -z "{value:-}" really makes shellcheck happy? This seems redundant. But at least makes the line happy

Good point. This is due to set -u which prevents the use of unbound variables.

This makes shellcheck happy.

[noissue]
@mdellweg mdellweg changed the title Make use of proper quoting in generate.sh New gen-client.sh for offline generation Jun 18, 2024
@mdellweg mdellweg force-pushed the app_label branch 5 times, most recently from ff896e2 to 99bf74f Compare June 18, 2024 13:28
This script focusses on generating the client from an api spec file. It
does not require access to a running pulp instance.

[noissue]
Copy link

@hstct hstct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this and verified that it fixes the client generation in oci-env with pulpcore 3.55+

@mdellweg mdellweg merged commit c3d5998 into pulp:main Jun 19, 2024
3 checks passed
@mdellweg mdellweg deleted the app_label branch June 19, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants