Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump openapi-generator-cli for ruby gen #101

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

pedro-psb
Copy link
Member

@pedro-psb pedro-psb commented Jul 2, 2024

This fixes the regression on ruby bindings introduced by a bugfix in drf-spectacular 0.27.0 (we were all relying on the bug). pulp/pulp_rpm#3639

I'm not sure what leap we wanna do here (latest is on 7.x currently). Known benefits for at least the 6.x bump are:

@pedro-psb pedro-psb force-pushed the bump/openapi-generator-image-for-ruby branch from 85f0b1f to 359297f Compare July 2, 2024 18:26
@pedro-psb pedro-psb force-pushed the bump/openapi-generator-image-for-ruby branch from 359297f to cb31f28 Compare July 3, 2024 19:58
@pedro-psb pedro-psb force-pushed the bump/openapi-generator-image-for-ruby branch from 305373d to 7d8dd2f Compare July 3, 2024 20:33
[noissue]
@pedro-psb
Copy link
Member Author

pedro-psb commented Jul 3, 2024

Some breaking change from 5.0.0 is breaking the ruby client.

They are exactly the same as the default ones, so they are useless here.

[noissue]
This is an umodified version.

[noissue]
@pedro-psb pedro-psb force-pushed the bump/openapi-generator-image-for-ruby branch from ba85bc5 to 92b6940 Compare July 5, 2024 15:35
@pedro-psb pedro-psb force-pushed the bump/openapi-generator-image-for-ruby branch from 6f1ebf9 to 830b72e Compare July 5, 2024 16:30
@pedro-psb
Copy link
Member Author

Some updates on this:

  • removed most of template files:
    • The ruby customization were actually incorporated into upstream (see here).
      As a consequence, they were exact copies and were not overriding anything, just confusing us.
    • the fact they are exact copies was verified by comparing (git diff) with the default filesof the version they were introduced (4.3.1).
  • fixed some dependecy issues
    • still, there were some depedency problems because we should use ruby 3.7 as a lowerbound (see katello pin). To fix that, I re-added gemspec.mustache template.
    • The conflict was that faraday max version under v3 which support ruby >2.6 is faraday<2.9.0 (see here)
  • more (unresolved)

@gerrod3
Copy link
Contributor

gerrod3 commented Jul 12, 2024

Is this the same as #98? Can these be merged together?

@pedro-psb
Copy link
Member Author

No. This PR you linked is bumping only the openapi-genrator-cli for python bindings.
This one is bumping the image for ruby bindings, which have a different set of related concerns.

@mdellweg
Copy link
Member

No. This PR you linked is bumping only the openapi-genrator-cli for python bindings. This one is bumping the image for ruby bindings, which have a different set of related concerns.

And they share the same concerns about being omnipresent changes for all release Branches throughout the project. In a way the could be seen as part of the same effort.

@pedro-psb
Copy link
Member Author

There is a request for adding tags/versioning to pulp-openapi-generator: #85. Maybe that's worth considering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants