New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the changelog extension check #916

Merged

lubosmj merged 1 commit into main from lubosmj-changelog-extension-check

Sep 30, 2024

Member

lubosmj commented Sep 30, 2024

No description provided.


          Fix the changelog extension check

30cbc1f

github-actions bot added no-changelog no-issue labels

Member Author

lubosmj commented Sep 30, 2024

In [1]: CHANGELOG_EXTS = {"feature", "bugfix", "doc", "removal", "misc"}

In [2]: from pathlib import Path

In [3]: Path("123123.feature").suffix
Out[3]: '.feature'

In [4]: Path("123123.feature").suffix in CHANGELOG_EXTS
Out[4]: False

In [5]: CHANGELOG_EXTS = {".feature", ".bugfix", ".doc", ".removal", ".misc"}

In [6]: Path("123123.feature").suffix in CHANGELOG_EXTS
Out[6]: True

git-hyagi approved these changes

View reviewed changes

mdellweg approved these changes

View reviewed changes

lubosmj merged commit 17472a1 into main

11 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog no-issue