Modify reason logic for release script to show all reasons for z release #915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdellweg
reviewed
Sep 26, 2024
Comment on lines
85
to
86
| grouped = (("Backports", z_changelog), ("requirements.txt", req_txt_diff)) | ||
| reasons = [r for r, c in grouped if c] |
There was a problem hiding this comment.
If you moved that calculation to before the if, we can have it's result as the if condition.
Would make it easier to add more reasons.
There was a problem hiding this comment.
Or we start the loop over branches with an empty "reasons", then check things one by one and add found reasons as we go.
There was a problem hiding this comment.
I don't understand your second point.
There was a problem hiding this comment.
Let me try to express myself in code:
reasons = []
if some_check:
reasons.append(SOME_REASON)
if some_other_check:
reasons.append(SOME_OTHER_REASON)
...
if reasons:
print(f"Hey, we have reasons: {reasons}")I think you would call this "The control flow goes with the data."
There was a problem hiding this comment.
I used to adopt this pattern whenever I want to collect warnings and errors over multiple operations.
gerrod3
force-pushed
the
small-release-reason
branch
from
882070a
to
01d0841
Compare
gerrod3
force-pushed
the
small-release-reason
branch
from
01d0841
to
fbc5649
Compare
mdellweg
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.