Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timeout #909

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Timeout #909

merged 1 commit into from
Aug 28, 2024

Conversation

mdellweg
Copy link
Member

No description provided.

@mdellweg mdellweg marked this pull request as ready for review August 27, 2024 19:59
ipanova
ipanova approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@ipanova ipanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me. I think 300s timeout should be enough, I vaguely remember that rpm plugin had some tests that would take 10mins+ but those I think were performance tests.

@mdellweg
Add pytest timeout
8c479ac 
Abort functional tests after 5 minutes to catch a good stacktrace on
stuck situations.
@mdellweg
Copy link
Member Author

Also you can @pytest.mark.timeout(600) individual tests.

@mdellweg mdellweg merged commit ece49c9 into pulp:main Aug 28, 2024
11 checks passed
@mdellweg mdellweg deleted the timeout branch August 28, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gerrod3 gerrod3 gerrod3 approved these changes

@ipanova ipanova ipanova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mdellweg @ipanova @gerrod3