Teach check_release to use tags to define next-version. #858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdellweg
reviewed
Apr 10, 2024
Comment on lines
80
to
84
| curr_version = Version(last_tag) | ||
| next_version = Version(f"{branch}.{curr_version.micro + 1}") |
There was a problem hiding this comment.
Fixing by deleting thirty lines. 👍
Do we want to add one sanity check that assert curr_version.startswith(branch) ?
ggainey
force-pushed
the
check_release-use-tags
branch
from
9d26835
to
9fc429b
Compare
mdellweg
approved these changes
Apr 17, 2024
Comment on lines
+81
to
+83
| assert curr_version.base_version.startswith( | ||
| branch | ||
| ), "Current-version has to belong to the current branch!" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[noissue]