-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve python version flexibility #845
Conversation
.github/workflows/build.yml
Outdated
@@ -26,7 +26,7 @@ jobs: | |||
fetch-depth: 0 | |||
- uses: actions/setup-python@v4 | |||
with: | |||
python-version: "3.8" | |||
python-version: "latest" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: none of these are in the template, it's the CI for the template itself
8c17c2a
to
0ef744f
Compare
2944218
to
ea15565
Compare
a1793f3
to
b6a3912
Compare
@gerrod3 Looking at the test failure.. this line of code doesn't even exist in recent versions, we replaced aiohttp a full year ago https://github.com/pulp/plugin_template/actions/runs/7911045981/job/21594626348?pr=845#step:15:133 https://github.com/pulp/pulpcore/pull/3575/files Any idea how this would be happening? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nitpick, but also not a thing i want to hold off for.
Let's get this forward with!
We need to update this bootstrap line: https://github.com/pulp/plugin_template/blob/main/templates/bootstrap/requirements.txt#L1 |
[noissue]
@gerrod3 @mdellweg If we want to keep the older branches of various plugins using the older CI images, and I assume we do if our goal is maximal stability, then we need to do a round of CI updates to set the The easiest way to do that is trigger the action right now prior to merging this PR, as it will fill out the default automatically. This is already done for pulpcore, pulp_rpm, and pulp_container but it doesn't look like ansible or gem are updated (beyond the main branch), and I don't have permissions to trigger the actions in those repos. |
pulp_gem and pulp_ansible have been updated. We still need to update pulp_ostree and pulp_deb. And do we need to do anything for pulp_file? |
pulp_file no longer has independent CI, so no. |
Stable branches do... |
That's true |
[noissue]