Remove workaround not publishing pulp-file client #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we can now publish clients for multiple plugins in one repository, this workaround is not needed anymore. Also it turned out to be evil on older pulpcore branches by installing the wrong version of the bindings. [noissue]
Pulpcore versions can change plugin apis in slight ways to make the generated api bindings incompatible. Until this is fixed, we need to stick to testing with specially generated client bindings for the very test run. [noissue]
mdellweg
force-pushed
the
remove_workaround
branch
from
837e2d2
to
7facb0a
Compare
lubosmj
approved these changes
Nov 23, 2023
|
I'd like to be able to revert them individually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we can now publish clients for multiple plugins in one repository, this workaround is not needed anymore. Also it turned out to be evil on older pulpcore branches by installing the wrong version of the bindings.
[noissue]