The package import for axi_test.sv used in floo_axi_test_node.sv was missing #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solomatnikov
reviewed
Feb 7, 2025
| @@ -5,6 +5,7 @@ | |||
| // Michael Rogenmoser <[email protected]> | |||
|
|
|||
| `include "axi/assign.svh" | |||
| import axi_test::*; | |||
|
|
|||
| /// A AXI4 Bus Master-Slave Node for generating random AXI transactions | |||
| module floo_axi_test_node #( | |||
There was a problem hiding this comment.
Suggested change
| module floo_axi_test_node #( | |
| module floo_axi_test_node import axi_test::*; #( |
|
This import should not be necessary in my opinion, if you use the classes from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
axi_test.sv is a package used inside floo_axi_test_node.sv. However this package was not imported inside the floo_axi_test_node.sv file leading to compilation errors