Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add max_domain_length setting to control length of generated FQDN #90

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Add max_domain_length setting to control length of generated FQDN #90

merged 2 commits into from
Sep 19, 2024

Conversation

crohr
Copy link
Member

@crohr crohr commented Sep 6, 2024

No description provided.

@crohr crohr added the pullpreview This label allows to start a PullPreview environment label Sep 6, 2024
@crohr crohr self-assigned this Sep 6, 2024
@github-actions github-actions bot removed the pullpreview This label allows to start a PullPreview environment label Sep 6, 2024
gael-connan-cybex
gael-connan-cybex approved these changes Sep 9, 2024
View reviewed changes
Copy link

@gael-connan-cybex gael-connan-cybex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with and without custom domain, works fine.

everything except the IP itself could be removed as well, when a small enough number is given, but it already works for us.

@crohr crohr merged commit d30cb3e into master Sep 19, 2024
4 checks passed
@crohr crohr deleted the feature/allow-max-domain-length-setting branch September 19, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gael-connan-cybex gael-connan-cybex gael-connan-cybex approved these changes

Assignees

@crohr crohr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crohr @gael-connan-cybex