Fixes flaky test #2006
Merged
Fixes flaky test #2006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hectorcorrea
commented
Jan 7, 2025
| @@ -96,7 +98,6 @@ | |||
| click_on "Grant License and Complete" | |||
| page.driver.browser.switch_to.alert.accept | |||
| expect(page).to have_content("5-10 business days") | |||
| expect(page).to have_content(work.title) | |||
There was a problem hiding this comment.
We don't display the title in https://github.com/pulibrary/pdc_describe/blob/main/app/views/works_wizard_submission_complete/show.html.erb (but how come this passed sometimes?)
hectorcorrea
commented
Jan 7, 2025
| @@ -83,6 +83,8 @@ | |||
|
|
|||
| click_on "Next" | |||
| expect(page).to have_css(validate_form_css) | |||
| # Force the work to have two files (readme + another file) | |||
| stub_s3 data: [FactoryBot.build(:s3_readme, work:), FactoryBot.build(:s3_file, work:)] | |||
There was a problem hiding this comment.
This seems to be the culprit. We are not adding a data file (other than the readme) and the code expects one. That's why the validation error in CI is actually indicating.
What I still don't understand is how come this passed sometimes but not others?
bess
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the flaky test for the Work Wizard.
I am not entirely sure how come this test passed sometimes but not others. If I am reading the spec correctly it should had always failed since (1) it does not add a data file to the work (it only adds the readme) and (2) the very last check for the "title" should always fail given that we don't display the file on the last step. ¯_(ツ)_/¯
Closes #2002