Skip to content

Commit

Permalink
Use only selenium-webdriver, not webdrivers (#619)
Browse files Browse the repository at this point in the history
- Failing in CI because of Chromedriver / Chrome mismatch
  • Loading branch information
maxkadel authored Aug 15, 2023
1 parent b983d6f commit 98c11fc
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 9 deletions.
2 changes: 0 additions & 2 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,5 @@ group :test do
gem 'selenium-webdriver'
gem 'simplecov', require: false
gem 'timecop'
# Easy installation and use of chromedriver to run system tests with Chrome
gem 'webdrivers'
gem 'webmock'
end
5 changes: 0 additions & 5 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -466,10 +466,6 @@ GEM
activemodel (>= 5.0)
bindex (>= 0.4.0)
railties (>= 5.0)
webdrivers (5.2.0)
nokogiri (~> 1.6)
rubyzip (>= 1.3.0)
selenium-webdriver (~> 4.0)
webmock (3.12.1)
addressable (>= 2.3.6)
crack (>= 0.3.2)
Expand Down Expand Up @@ -550,7 +546,6 @@ DEPENDENCIES
tzinfo-data
vite_rails (~> 3.0)
web-console (>= 3.3.0)
webdrivers
webmock
whenever

Expand Down
2 changes: 0 additions & 2 deletions spec/support/system_specs.rb
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,13 @@
end

config.before(:each, type: :system, js: true) do
Webdrivers::Chromedriver.required_version = "114.0.5735.90"
if ENV["RUN_IN_BROWSER"]
driven_by(:selenium_chrome)
else
driven_by(:selenium_chrome_headless)
end
end
config.before(:each, type: :system, js: true, in_browser: true) do
Webdrivers::Chromedriver.required_version = "114.0.5735.90"
driven_by(:selenium_chrome)
end
config.after(:each, type: :system, js: true) do
Expand Down

0 comments on commit 98c11fc

Please sign in to comment.