Use case insensitive matching (#720)

pulibrary · Mar 14, 2024 · 8ea7084 · 8ea7084
1 parent fa0e961
commit 8ea7084
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 1 deletion.
diff --git a/app/models/oclc/lc_call_slips/record.rb b/app/models/oclc/lc_call_slips/record.rb
@@ -38,7 +38,7 @@ def class_relevant_to_selector?(selector:)
       def subject_relevant_to_selector?(selector:)
         return false unless selector.subjects
 
-        subjects.any? { |subject| subject.downcase.match?(/#{selector.subjects.join('|')}/) }
+        subjects.any? { |subject| subject.match?(/#{selector.subjects.join('|')}/i) }
       end
 
       def author

diff --git a/spec/models/oclc/lc_call_slips/record_spec.rb b/spec/models/oclc/lc_call_slips/record_spec.rb
@@ -51,6 +51,28 @@
         expect(oclc_record.relevant_to_selector?(selector:)).to eq(false)
       end
     end
+    context 'with capitalization in the config file subjects' do
+      let(:selector_config) do
+        { hatfield: {
+          classes: [{ class: 'X', low_num: 0, high_num: 99_999 }],
+          subjects: ['Judaism']
+        } }
+      end
+      let(:fields) do
+        [
+          { '650' => { "ind1" => "",
+                       "ind2" => "0",
+                       'subfields' => [
+                         { 'a' => 'Judaism' }
+                       ] } }
+        ]
+      end
+
+      it 'uses case insensitive matching' do
+        expect(oclc_record.subject_relevant_to_selector?(selector:)).to eq(true)
+        expect(oclc_record.relevant_to_selector?(selector:)).to eq(true)
+      end
+    end
   end
 
   describe 'call number parsing' do