Properly close the GZip::Writer

Co-authored-by: Christina Chortaria <[email protected]>

app/models/alma_submit_collection/marc_s3_writer.rb

@@ -39,8 +39,8 @@ def done
         compressed = StringIO.new
         compressor = Zlib::GzipWriter.new(compressed)
         compressor.write file_contents.read
-        compressor.flush
-        client.put_object(bucket:, body: compressed, key: "#{Rails.configuration.scsb_s3[:scsb_s3_updates]}/scsb_#{File.basename(file_path)}")
+        compressor.close
+        client.put_object(bucket:, body: compressed.string, key: "#{Rails.configuration.scsb_s3[:scsb_s3_updates]}/scsb_#{File.basename(file_path)}")
       end
       @current_file.unlink
     end
@@ -49,7 +49,7 @@ def done
 
     def filename_components
       components = ["scsb_submitcollection_#{@file_type}"]
-      components << "#{Time.current.iso8601}.marcxml"
+      components << "#{Time.current.iso8601}.marcxml.gz"
       components
     end
 

spec/models/alma_submit_collection/marc_file_processor_spec.rb

@@ -33,7 +33,7 @@
       stub_alma_bibs(ids: constituent_ids, status: 200, fixture: "constituent_records.xml", apikey: '1234')
       s3_client.stub_responses(
         :put_object, lambda { |context|
-          files_sent_to_s3 << Zlib::GzipReader.new(context.params[:body])
+          files_sent_to_s3 << Zlib::GzipReader.new(StringIO.new(context.params[:body]))
         }
       )
     end

spec/models/alma_submit_collection/marc_s3_writer_spec.rb

@@ -9,7 +9,7 @@
       files_sent_to_s3 = []
       s3_client.stub_responses(
         :put_object, lambda { |context|
-          files_sent_to_s3 << Zlib::GzipReader.new(context.params[:body])
+          files_sent_to_s3 << Zlib::GzipReader.new(StringIO.new(context.params[:body]))
         }
       )