Update universalviewer from 3 to 4, use package via yarn #5810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hackartisan
force-pushed
the
5778-uv-update
branch
from
cd5819b to
f82259e
Compare
eliotjordan
force-pushed
the
5778-uv-update
branch
from
9487092 to
220a608
Compare
hackartisan
force-pushed
the
5778-uv-update
branch
3 times, most recently
from
3577cb6 to
34f06f6
Compare
|
Notes we're taking while we work on this: https://docs.google.com/document/d/1CD2BucVBFki0ujtUGiApOQc340Ts4sYLcNZjoI9kbjw/edit |
hackartisan
force-pushed
the
5778-uv-update
branch
from
862cf19 to
7545584
Compare
hackartisan
commented
Aug 21, 2023
| @@ -2,6 +2,7 @@ | |||
| <head> | |||
| <meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0, user-scalable=no" /> | |||
| <%= csrf_meta_tag %> | |||
| <script src="https://cdn.jsdelivr.net/npm/hls.js@1"></script> | |||
There was a problem hiding this comment.
Does it not work without this? If the mime type is the fix maybe bringing in hls via vite is sufficient?
Co-authored-by: Trey Pendragon <[email protected]>
which includes changes to av-component
This doesn't make audio work though
Co-authored-by: Anna Headley <[email protected]>
eliotjordan
force-pushed
the
5778-uv-update
branch
from
3a70491 to
1bb4891
Compare
Co-authored-by: Anna Headley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to test custom use cases.
closes #5778