Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Measure Hydration/Transformation/Indexing Times #153

Merged
merged 24 commits into from
Dec 4, 2024
Merged
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Relocate function.
tpendragon committed Nov 27, 2024
commit 019182daae4e1704adc26333130bc4b0496099b4
8 changes: 4 additions & 4 deletions lib/dpul_collections/index_metrics_tracker.ex
Original file line number Diff line number Diff line change
@@ -153,6 +153,10 @@ defmodule DpulCollections.IndexMetricsTracker do
|> put_in([:acked_count], old_acked_count + new_acked_count)
end

defp handle_ack_received([:database_producer, :ack, :done], _measurements, metadata, _config) do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why does this one recurse?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because I should probably call that function something different

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename to ack_telemetry_callback

GenServer.call(__MODULE__, {:ack_received, metadata})
end

def event("figgy_hydrator") do
:hydrator
end
@@ -164,8 +168,4 @@ defmodule DpulCollections.IndexMetricsTracker do
def event("figgy_indexer") do
:indexer
end

defp handle_ack_received([:database_producer, :ack, :done], _measurements, metadata, _config) do
GenServer.call(__MODULE__, {:ack_received, metadata})
end
end