Update staff url to new format (#246)

* Update staff url to new format * actually replace and downcase url * escaping url for special characters --------- Co-authored-by: Ryan Laddusaw <[email protected]>
pulibrary · Jul 15, 2024 · 2310876 · 2310876
1 parent 1f9f995
commit 2310876
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/app/models/library_staff_document.rb b/app/models/library_staff_document.rb
@@ -82,7 +82,10 @@ def type
   def description; end
 
   def url
-    "https://library.princeton.edu/staff/#{document.netid}"
+    staff_url = "https://library.psb-prod.princeton.edu/people/#{document.first_name}-#{document.last_name}"
+                .gsub(' ', '-')
+                .downcase
+    URI::Parser.new.escape(staff_url)
   end
 
   def doc_keys

diff --git a/spec/requests/library_staff_spec.rb b/spec/requests/library_staff_spec.rb
@@ -12,7 +12,7 @@
         title: 'Trout, Nimbus',
         id: 00_0000_002,
         type: 'Library Staff',
-        url: 'https://library.princeton.edu/staff/nimbuskt',
+        url: 'https://library.psb-prod.princeton.edu/people/nimbus-kilgore-trout',
         other_fields: {
           building: 'Firestone Library',
           department: 'Office of the Deputy Dean of Libraries',