Keep reference to this

[Artazor]

Hi. I'm working on semi-conservative refactoring of mixins in jade (all existing unit tests are passed, only private api slightly changed) to make them first class objects, as well as proper handling of this refernece in templates. In classical jade this reference is used for passing of {block,attributes} to the mixin like

    var buf, jade // runtime vars enclosed into template's closure 
    mixin.call({block,attributes}, args...)

I've refactored lexer/parser/compiler + with
to make mixins essentialy a curried functions while decoupling them from jade-runtime and buf:

      mixin(args...)(attributes,block)(buf, jade)

so now mixins can be compiled separately with jade.compileMethod(src, options) and passed as parameters for templates, or attached to function prototype to make templates as methods, or simply bound by mixin.bind(someobj)

also i've added first-class mixin call syntax

       +[expression_that_evaluates_to_mixin]#id.class(data-test=123)(arg1,agr2,arg3)
             span I'm in block
       +[jade_mixins["test"]](1,2,3)
       +test(1,2,3)
       +[obj.renderView] //- this was a primary goal

All this features are based on small enhancement of with module to make it respectful for this reference.
My semantics/syntax for mixins is arguable but I hope that at least this change in with matters and can be merged.

Regards, Anatoly
P.S. my fork of jade is here https://github.com/Artazor/jade - it would be great to hear any comments about that direction

[ForbesLindesay]

Can we fix this to use .call(this, ...args) rather than .bind(this)(...args)

[Artazor]

Sure!

[Artazor]

Stop!!! Then you should change AST checking too! otherwise it will fail.

[Artazor]

Oh I see, you've changed AST checking too -)
Sorry, I'm thinking at lower speed than you probably

[ForbesLindesay]

FYI, I like the idea of making mixins first class values that can be passed around until they are used. I'm not entirely clear on the relevance of this here and the syntax may need a little more bike-shedding before it is merged. I'd like to have that discussion in the jade repo though, where the relevant people can watch, so please open an issue there so that this can be discussed, or add your thoughts to existing issues.

[ForbesLindesay]

As for this pull request, there is no question about it, this should be supported by with.

[Artazor]

Hi! Thank you for the reply! I'm working on the text for the detailed
explanation and it will be in jade's issues soon (as proposal)
On Aug 19, 2014 7:59 PM, "Forbes Lindesay" [email protected] wrote:

FYI, I like the idea of making mixins first class values that can be
passed around until they are used. I'm not entirely clear on the relevance
of this here and the syntax may need a little more bike-shedding before
it is merged. I'd like to have that discussion in the jade repo though,
where the relevant people can watch, so please open an issue there so that
this can be discussed, or add your thoughts to existing issues.

—
Reply to this email directly or view it on GitHub
#3 (comment).

[ForbesLindesay]

I've merged this manually, with a small modification. Thanks for the contribution!