Merge pull request #9 from jonathanong/never-pass-undefined-as-an-arg…

…ument never pass `undefined` as an argument
pugjs · Apr 8, 2015 · 03b473d · 03b473d
2 parents 495b1f4 + 78c6b4a
commit 03b473d
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/index.js b/index.js
@@ -45,6 +45,7 @@ function addWith(obj, src, exclude) {
   var vars = detect(src).map(function (global) { return global.name; })
     .filter(function (v) {
       return exclude.indexOf(v) === -1
+        && v !== 'undefined'
     })
 
   if (vars.length === 0) return src

diff --git a/test/index.js b/test/index.js
@@ -153,6 +153,15 @@ describe('addWith("obj || {}", "return this[foo]")', function () {
     assert(obj.fn(obj) === 'ding')
     done()
   })
+
+  it('does not pass `undefined` as an argument', function (done) {
+    var src = addWith('obj || {}', 'return this[foo]')
+    assert(!~src.indexOf('"undefined" in locals_for_with'))
+    assert(!~src.indexOf('locals_for_with.undefined'))
+    assert(!~src.indexOf('typeof undefined!=="undefined"?undefined:undefined'))
+    outputs.push(src)
+    done()
+  })
 })
 describe('addWith("obj", "var x = (y) => y + z; x(10);")', function () {
   it('keeps reference to this', function (done) {