Paragraph selector #999
Merged
Paragraph selector #999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allisonking
commented
Feb 26, 2025
| @@ -0,0 +1,89 @@ | |||
| import { lift, setBlockType, wrapIn } from "prosemirror-commands"; | |||
There was a problem hiding this comment.
pretty much lifted from legacy
allisonking
commented
Feb 26, 2025
| @@ -0,0 +1,32 @@ | |||
| import type { MarkType } from "prosemirror-model"; | |||
There was a problem hiding this comment.
also lifted from legacy—this pattern of creating toggles is much more flexible than what I originally had when it was only bold/italics
allisonking
commented
Feb 26, 2025
| @@ -0,0 +1,48 @@ | |||
| import type { Mark, MarkType, Node, NodeType, Schema } from "prosemirror-model"; | |||
There was a problem hiding this comment.
lifted from legacy
allisonking
commented
Feb 26, 2025
| @@ -0,0 +1,27 @@ | |||
| import type { EditorState } from "prosemirror-state"; | |||
There was a problem hiding this comment.
lifted from legacy
3mcd
approved these changes
Feb 27, 2025
| const activeType = paragraphTypeItems.filter((item) => { | ||
| const { isActive } = item.command(view)(view.state); | ||
| return isActive; | ||
| })[0]; |
There was a problem hiding this comment.
Could be simplified like so:
paragraphTypeItems.find((item) => item.command(view)(view.state).isActive)
Co-authored-by: Eric McDaniel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue(s) Resolved
Paragraph, heading, and blockquote part of #938
High-level Explanation of PR
Adds a paragraph/heading selector, as well as the ability to add blockquotes
Test Plan
Run storybook in the context editor folder, and play around with making paragraphs/headings/blockquotes.
Screenshots (if applicable)
Screen.Recording.2025-02-26.at.3.46.10.PM.mov
Screen.Recording.2025-02-26.at.3.48.18.PM.mov
Notes
The blockquote heading doesn't look great because it overlaps with the paragraph heading. not sure what should be done here? haven't looked into that code too much yet to see how we'd tweak the positioning
