Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pub create/edit form grow to container #980

Merged
merged 3 commits into from
Feb 19, 2025
Merged

fix: pub create/edit form grow to container #980

merged 3 commits into from
Feb 19, 2025

Conversation

3mcd
Copy link
Member

@3mcd 3mcd commented Feb 18, 2025

Issue(s) Resolved

Resolves #962

High-level Explanation of PR

Quick fix to make the pub create/edit forms a bit wider.

Test Plan

  1. Open the pub create and edit forms and observe that they are now wider!

Screenshots (if applicable)

Screenshot 2025-02-18 at 12 36 27 PM

Notes

@3mcd 3mcd requested review from tefkah and allisonking February 18, 2025 17:38
tefkah
tefkah approved these changes Feb 19, 2025
View reviewed changes
Copy link
Member

@tefkah tefkah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but don't know why the tests are failing!

@3mcd 3mcd merged commit b003365 into main Feb 19, 2025
6 checks passed
@3mcd 3mcd deleted the em/form-width branch February 19, 2025 22:36
@allisonking allisonking mentioned this pull request Mar 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tefkah tefkah tefkah approved these changes

@allisonking allisonking Awaiting requested review from allisonking

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make sure forms have minimum width
2 participants
@3mcd @tefkah