Sticky editor menu #977
Merged
Sticky editor menu #977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allisonking
force-pushed
the
aking/937/sticky-menu
branch
from
28034dd to
68c803f
Compare
allisonking
commented
Feb 19, 2025
| suggestData, | ||
| setSuggestData | ||
| ), | ||
| new Plugin({ |
There was a problem hiding this comment.
it's easier to include this plugin here rather than in basePlugins since this one needs access to pluginViewFactory which we get from the hook
allisonking
commented
Feb 19, 2025
| import type { MarkType } from "prosemirror-model"; | ||
| import type { EditorState } from "prosemirror-state"; | ||
|
|
||
| export const markIsActive = (markType: MarkType, editorState: EditorState) => { |
There was a problem hiding this comment.
took this from legacy
3mcd
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue(s) Resolved
Closes #937
Closes #941
Closes #942
High-level Explanation of PR
Adds a menu bar to the context editor which can stick to the top of an editor. The editor needs to have a
max-heightandoverflow: scrollfor the stickiness to kick in.Test Plan
pnpm run storybookinpackages/context-editorand play with the editor!Or, to see it in the app:
Screenshots (if applicable)
demo of bold/italic commands
Screen.Recording.2025-02-19.at.10.25.22.AM.mov
it's sticky!
Screen.Recording.2025-02-19.at.10.30.00.AM.mov
Notes
I based the bold and italic input rules off of the inline code one in legacy:
https://github.com/pubpub/pubpub/blob/4e39976b74a7204cb5703f2b5e5b2cf7f2ce3233/client/components/Editor/plugins/inputRules.ts#L45-L57
including the space at the end to trigger the rule. I thought the space was unnecessary at first, but I think in this case where the editor is applying rules as soon as the user types, it's necessary for
*italic*vs**bold**, otherwise**bold**can never trigger. (It works for things like this GH editor because you have to navigate to the preview view which can then figure out you mean to bold instead of seeing**bold*and immediately making it '*bold'