Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: remove trailing semicolons #894

Closed
wants to merge 1 commit into from
Closed

RFC: remove trailing semicolons #894

wants to merge 1 commit into from

Conversation

3mcd
Copy link
Member

@3mcd 3mcd commented Jan 13, 2025

Issue(s) Resolved

N/A

High-level Explanation of PR

I like to omit trailing semicolons in JS projects because I feel they increase the visual noise of code. I also find code without trailing semicolons more aesthetically pleasing.

Perhaps more convincingly, there appears to be an increasing trend to omit trailing semicolons in open source projects. I took a sample of JS/TS projects from my GitHub feed to get a (very) rough estimate of the number of projects that use trailing semicolons vs. those that do not. I navigated to the six most recently updated projects in my feed and opened a random TS or JS source file:

Each of the six projects I visited eschewed use of trailing semicolons.

I feel we should adopt this standard to catch up to the current code style conventions of JS projects. And selfishly for the subjective reasons I listed above.

Test Plan

N/A

@3mcd 3mcd changed the title style: remove trailing semicolons RFC: remove trailing semicolons Jan 13, 2025
@3mcd 3mcd requested review from tefkah and allisonking January 13, 2025 17:11
@tefkah
Copy link
Member

tefkah commented Jan 13, 2025

I'm totally on board for this, only considerations:

  • This messes up git blame a bit, will make it harder to figure out when things were changed
  • Ideally: could this wait until we (know whether we want to) merge some of the PRs I have open? I fear this would introduce a bunch of annoying merge conflicts, which are much easier to solve on this end (just run pnpm format:fix on main again)

otherwise, let's gooo

@3mcd
Copy link
Member Author

3mcd commented Jan 13, 2025

@tefkah Sounds good. This will be easy to reconcile with main when we get everything else merged.

@3mcd 3mcd closed this Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants