Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove declaration of server-actions #341

Merged
merged 1 commit into from
May 7, 2024

Conversation

ships
Copy link
Collaborator

@ships ships commented May 6, 2024

Issue(s) Resolved

These configs were removed in the build-time next.config.js when we updated to next 14, which enables them by default.

However, we have these minimal "runtime next.docker.config.js" files that are loaded into the docker image for configurations that are demanded by next at runtime (currently, only the instrumentationHook directive.

Test Plan

Once this is deployed, we can see that during boot-up, containers don't emit this (benign) warning:

May 06, 2024 at 16:06 (UTC-7:00)	⚠ Server Actions are available by default now, `experimental.serverActions` option can be safely removed.	[180246665e1c470db51fe475bfbb090b](https://us-east-1.console.aws.amazon.com/ecs/v2/clusters/blake-ecs-cluster-staging/services/blake-integration-evaluations/tasks/180246665e1c470db51fe475bfbb090b?region=us-east-1)	integration-evaluations
May 06, 2024 at 16:06 (UTC-7:00)	⚠ Invalid next.config.js options detected:	[180246665e1c470db51fe475bfbb090b](https://us-east-1.console.aws.amazon.com/ecs/v2/clusters/blake-ecs-cluster-staging/services/blake-integration-evaluations/tasks/180246665e1c470db51fe475bfbb090b?region=us-east-1)	integration-evaluations
May 06, 2024 at 16:06 (UTC-7:00)	⚠ Expected object, received boolean at "experimental.serverActions"

in logs.

Screenshots (if applicable)

Optional

Notes/Context/Gotchas

The configuration spread between two files like this is unfortunate, but some build-time directives fail to load at run-time with the minimal dependency set for production. Probably it is reasonable to import these files into the main next.config.js rather than maintain the instrumentationHook directly, but this doesn't really solve the problem that a dev who adds a runtime config needs to know to put it here rather than in the "normal" place.

However, since we are only just getting started normalizing the docker workflow, we have no evidence this is really painful. So let's let it play out for now.

Supporting Docs

@ships ships requested review from kalilsn and 3mcd May 6, 2024 23:34
@ships ships enabled auto-merge (squash) May 7, 2024 23:41
Now that they are enabled by default in nextjs 14.
@ships ships force-pushed the ships/chore/remove-deprecated-config-server-actions branch from 43a4672 to 8133f0a Compare May 7, 2024 23:42
@ships ships merged commit ae535d8 into main May 7, 2024
7 checks passed
@ships ships deleted the ships/chore/remove-deprecated-config-server-actions branch May 7, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants