Remove declaration of server-actions #341
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue(s) Resolved
These configs were removed in the build-time next.config.js when we updated to next 14, which enables them by default.
However, we have these minimal "runtime next.docker.config.js" files that are loaded into the docker image for configurations that are demanded by next at runtime (currently, only the
instrumentationHook
directive.Test Plan
Once this is deployed, we can see that during boot-up, containers don't emit this (benign) warning:
in logs.
Screenshots (if applicable)
Optional
Notes/Context/Gotchas
The configuration spread between two files like this is unfortunate, but some build-time directives fail to load at run-time with the minimal dependency set for production. Probably it is reasonable to import these files into the main
next.config.js
rather than maintain theinstrumentationHook
directly, but this doesn't really solve the problem that a dev who adds a runtime config needs to know to put it here rather than in the "normal" place.However, since we are only just getting started normalizing the docker workflow, we have no evidence this is really painful. So let's let it play out for now.
Supporting Docs