-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Playwright Integration Testing #335
Conversation
Adding this here for context for myself: TODO
Future work and follow up to this should be:
|
45500a9
to
bf6b31a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great so far! But for me, the tests timeout against the dev server even after it's warmed up. I'm ok with merging this without them passing, but I don't think it's practical to run them against the dev server in CI (or in general really) so the next step is definitely making sure we can run them against the compiled app.
I also wanted to mention that there's an additional setup step required that's not in your test instructions: pnpm --filter core exec playwright install
to make sure the browsers are installed.
strange. they are failing for me as well. they were not earlier. let me look into this |
f7bba33
to
87175aa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are passing as long as they don't time out for me, looks great!
Issue(s) Resolved
#291
Test Plan
run
nvm use
run
pnpm i
run
pnpm --filter core run reset
run
pnpm dev
in another terminal tab:
run the integration test using
pnpm --filter core run playwright:test
to view test in your terminalrun the integration test using
pnpm --filter core run playwright:ui
to view test in a uiIf you install the playwright plugin you can do the testing from vscode in the testing tab. you still need to run the server.
Screenshots (if applicable)
Optional
Notes/Context/Gotchas
There is no teardown and setup steps yet, where authentication and setting up test data would normally go, so when running the assign test the pub really will be assigned
Supporting Docs